[world conquest] [artifact/abilities] Make banner stack with leadership ability. #6467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes banner not stacking with leadership
github-actions
bot
added
the
Campaign (any)
knyghtmare
added
Backport
|
you must ever pull cumulative=no for what case of negative value don't relaced by zero. |
|
I try to resolve issue with #6468. |
I will have a go at testing it then. Need to rebuild my client first. |
|
Is this waiting for review, or waiting for testing? My current feeling is that I'd be happy to merge this to master now, even though #6468 is also going to be merged to master. After review (and maybe changes) I intend to merge #6468 to master, but not to backport that (because it's an API change). |
It has been tested and works too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes banner not stacking with leadership
Addresses point 8 of #6411