1.16 variations 20220129 #6477
Merged
1.16 variations 20220129 #6477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Graphics
|
So the transition looks different, but there's no functionality change anywhere? |
Wedge009
added
the
Fwdport
|
Right. Here's a screenshot. It affects the appearance of Xos when it is next to frozen terrain. Other Xo* aren't affected, and I can't think of a reason anyone would want the default Xos on snow/ice. It's got an issue or two with corner cases (lower-right in the screenshot), but I think it's an improvement for most cases. |
|
Alright, that sounds fine for 1.16. |
doofus-01
added a commit
that referenced
this pull request
Feb 7, 2022
Asheviere
pushed a commit
to Asheviere/wesnoth
that referenced
this pull request
Feb 18, 2022
* icy stone walls variation for Xos, based on adjacent terrain, not new code * more variations for rocks, rubble, and snowbits
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not completely sure these can go into 1.16. They only change the appearance slightly and won't break anything outright, but new transition behavior between terrain codes Xos and Aa might be too much for stable?