Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update credits #6481

Merged
merged 1 commit into from Feb 7, 2022
Merged

Update credits #6481

merged 1 commit into from Feb 7, 2022

Conversation

czyzby
Copy link
Contributor

@czyzby czyzby commented Feb 1, 2022

Add missing entry to the about.cfg file. See #6475.

@stevecotton
Copy link
Contributor

My apologies for asking you to create this PR before I asked @doofus-01 about whether the credit should go in the Artists or Miscellaneous Contributors section.

@doofus-01, please would you say which section this should be in?

@czyzby
Copy link
Contributor Author

czyzby commented Feb 1, 2022

@stevecotton I didn't realize that sprite changes can be credited in a different section. Feel free to close the PR if you'd prefer to update the credits in bulk once the details are established.

Copy link
Member

@doofus-01 doofus-01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The credits are a mess, I don't think the section matters much at this point. More important is to get the "comment" key to be an accurate description, and that part looks OK to me.

@stevecotton stevecotton merged commit bb0206d into wesnoth:master Feb 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants