Add-ons manager: handle the selected add-on changing in small-screen mode #6490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mode Fix another instance of issue wesnoth#3059, where code assumes that all parts of the add-ons manager's UI are accessible, an assumption that fails when the dialog uses a stacked widget to handle small window sizes. The up and down arrow keys select the previous or next add-on in the list, even when the small-window layout is hiding the list. That feels like a feature rather than a bug, as it's useful and an understandable UX; however it needs the fix in this commit so that on_addon_select() doesn't throw an exception and close the dialog. The new code is the same as the fix that 050feb6 applied to on_selected_version_change, traversing the stacked widget to get the info.
stevecotton
added
Bug
Wedge009
approved these changes
Feb 8, 2022
|
Thanks, and I'm forward-porting it now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix another instance of issue #3059, where code assumes that all parts of the
add-ons manager's UI are accessible, an assumption that fails when the dialog
uses a stacked widget to handle small window sizes.
The up and down arrow keys select the previous or next add-on in the list,
even when the small-window layout is hiding the list. That feels like a feature
rather than a bug, as it's useful and an understandable UX; however it needs
the fix in this commit so that on_addon_select() doesn't throw an exception
and close the dialog. The new code is the same as the fix that 050feb6
applied to on_selected_version_change, traversing the stacked widget to get the
info.
Fixes #6485.