Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.17 minor terrain fixes #6492

Merged
merged 6 commits into from Mar 6, 2022
Merged

Conversation

doofus-01
Copy link
Member

1.17 version of #6488

@github-actions github-actions bot added Graphics Issues that involve the graphics engine or assets. Terrain Issues that involve terrain definitions or their implementation in the engine. labels Feb 6, 2022
@stevecotton
Copy link
Contributor

Remember to use woptipng on the new files.

@stevecotton
Copy link
Contributor

Where do the graphics for the help pages come from? Ai^Dc looks good on a map, but its help page shows ice with a desert crater.

@doofus-01
Copy link
Member Author

Accessing the terrains in the side-tree just shows the individual terrains, as you'd expect. Would it make sense to append the base+overlay info accessed from the map, rather than trying (apparently not always successfully) to merge them?

There isn't a lot of info in the non-debug description anyway (in 1.16 at least), a simple link page to the two separate terrain pages could also be an option. So, don't have a page for Ai^Dc, just a page for Ai and a page for ^Dc.

@doofus-01 doofus-01 merged commit 8b059e5 into wesnoth:master Mar 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Graphics Issues that involve the graphics engine or assets. Terrain Issues that involve terrain definitions or their implementation in the engine.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants