Replace deprecated share_maps and share_view with share_vision

[Wedge009]

Closes #6496.

Not sure if I'm understanding the documentation correctly but I interpreted share_maps=yes as share_vision=shroud and share_view=yes as share_vision=all.

Also not sure if it's worth back-porting, since there's the potential to break compatibility for games in progress. But if reviewers think it's okay, I can back-port too.

[Wedge009]

Hmm, where are those ...share_view tests defined? Did it break just because I renamed the tests to match the updated code?

[stevecotton]

The file wml_test_schedule.

[knyghtmare]

Were all the edited scenarios checked to see if the update works as intended? Otherwise we might be preparing for a flood of bugs.

[knyghtmare]

Also, it goes like this:
if share_maps (it means shroud data), so just share_vision=shroud
if share_view (it means fog), so share_vision=all
Share_vision has no specific value for "just FoW" so in those cases it should be set for "all".

In any case, the edits look fine.

[Wedge009]

Were all the edited scenarios checked to see if the update works as intended?

I checked the test scenario and a few of the campaign scenarios and didn't see anything obviously wrong but I'd still prefer for others to check this as I'm not entirely sure of 'correct' behaviour.

Also, it goes like this: if share_maps (it means shroud data), so just share_vision=shroud if share_view (it means fog), so share_vision=all Share_vision has no specific value for "just FoW" so in those cases it should be set for "all".

That's basically how I read it too.

[stevecotton]

All looks good to me. I haven't tested in-game.

[Wedge009]

Should I wait till someone else does some testing before merging?

[stevecotton]

I've tested all the campaign changes except for the LoW ones. The LoW ones look right, but as it's getting rewritten anyway I didn't see the need to test.

My feeling is to merge, but as it's campaign content I think the decision has to be made by @nemaara rather than me.

[nemaara]

Upcoming rework has no bearing on making improvements to the current version.

[stevecotton]

@Wedge009 I've added a few comments about possibly adding comments, but feel free to merge as-is or with those as you feel appropriate.

[Wedge009]

@stevecotton Thanks for your review. If you can just double-check the second commit relating to the sharing of Chantal's side's vision and advise whether or not it's okay, then I'll merge or correct accordingly.

[stevecotton]

I think it makes sense to backport all of this. Now we've tested DM S11 on 1.16, I'm confident that these changes won't introduce any bugs.

[Wedge009]

Back-ported with 80c9263 + c80f83d + 28ce494.