Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove only_active argument to weapon_specials() #6507

Merged
merged 2 commits into from Feb 11, 2022

Conversation

newfrenchy83
Copy link
Contributor

weapon_specials only called in unit_attack.cpp, only_active argument don't usable

@github-actions github-actions bot added UI User interface issues, including both back-end and front-end issues. Units Issues that involve unit definitions or their implementation in the engine. labels Feb 10, 2022
@stevecotton
Copy link
Contributor

There's some documentation on that function that should be updated too.

If we merge this now, would you be happy to merge this exact change onto 1.17 too and then rebase the bigger PR on top? Otherwise I'd prefer to only merge things that can be applied to both 1.16 and 1.17.

@newfrenchy83
Copy link
Contributor Author

There's some documentation on that function that should be updated too.

If we merge this now, would you be happy to merge this exact change onto 1.17 too and then rebase the bigger PR on top? Otherwise I'd prefer to only merge things that can be applied to both 1.16 and 1.17.

merge change into 1.16/1.17 and rebase big PR. i will update documentation.

@newfrenchy83 newfrenchy83 changed the title (1.16) remove only_active argument to weapon_specials() remove only_active argument to weapon_specials() Feb 10, 2022
@newfrenchy83
Copy link
Contributor Author

Documentation corrected

@stevecotton stevecotton merged commit e348e6d into wesnoth:1.16 Feb 11, 2022
@stevecotton
Copy link
Contributor

Oops, I forgot to squash those into a single commit.

@newfrenchy83 newfrenchy83 deleted the remove_is_active_argument branch February 11, 2022 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
UI User interface issues, including both back-end and front-end issues. Units Issues that involve unit definitions or their implementation in the engine.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants