Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HttT S17: Update to comply with current Wesnoth Lua API specifications #6526

Merged
merged 1 commit into from Feb 16, 2022

Conversation

Wedge009
Copy link
Member

Resolves #6517

It might be obvious to experienced Lua API users but it's not a direct translation to map.special_locations as per https://wiki.wesnoth.org/LuaAPI/UpdatingFrom14, but rather wesnoth.current.map.special_locations.

I tested this in master and believe it can/should be back-ported to 1.16.

@Wedge009 Wedge009 added Backport A reminder of a bugfix that was added to master that needs to be duplicated on the stable branch. Campaign (any) Deprecated tag, replaced with separate tags for each mainline campaign Lua API Issues with the Lua engine and API. labels Feb 16, 2022
@CelticMinstrel
Copy link
Member

CelticMinstrel commented Feb 16, 2022

It might be obvious to experienced Lua API users but it's not a direct translation to map.special_locations as per https://wiki.wesnoth.org/LuaAPI/UpdatingFrom14, but rather wesnoth.current.map.special_locations.

That is what the linked page says though – right at the top is a note explaining that wesnoth.current.map has been abbreviated to map.

EDIT: Top of the section, not the page

@Wedge009
Copy link
Member Author

Wedge009 commented Feb 16, 2022

Oh, okay. I completely missed that note because I just did a search for 'special_locations'. Even knyght made no mention of it in #6517.

@stevecotton
Copy link
Contributor

Please would you change the commit message to have "HttT S17" in the title? When looking at the history later, the current "Comply with current Lua API specifications" will sound like something to do with Vultraz' "Upgrade to Lua 5.4.4" change.

wesnoth.special_locatioons is deprecated.

Resolves wesnoth#6517
@Wedge009 Wedge009 changed the title HttT S17: Update to comply with current Lua API specifications HttT S17: Update to comply with current Wesnoth Lua API specifications Feb 16, 2022
@Wedge009
Copy link
Member Author

It looks like the CI failures were introduced with #6527, not this very small change.

@stevecotton
Copy link
Contributor

Schema verification and WML tests all passed, so I'm happy to merge this without rerunning the CI (I believe rerunning the job without pushing a new commit would retry with the exact same source, excluding the fix for the Doxygen issue).

@stevecotton stevecotton merged commit 47ec300 into wesnoth:master Feb 16, 2022
@Wedge009 Wedge009 deleted the lua_special_locations branch February 16, 2022 22:51
@Wedge009
Copy link
Member Author

Thank you for merging. Back-ported in 0607f31.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backport A reminder of a bugfix that was added to master that needs to be duplicated on the stable branch. Campaign (any) Deprecated tag, replaced with separate tags for each mainline campaign Lua API Issues with the Lua engine and API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HttT S17: Uses deprecated wesnoth.special_locations table
3 participants