Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[world conquest] update deprecated share_view to share_vision #6536

Merged
merged 1 commit into from Feb 19, 2022
Merged

[world conquest] update deprecated share_view to share_vision #6536

merged 1 commit into from Feb 19, 2022

Conversation

knyghtmare
Copy link
Member 

share_view = true,

To:

share_vision = "all",

@knyghtmare
[world conquest] update deprecated share_view
11e3d43 
'share_view = true' => 'share_vision = "all"'
@github-actions github-actions bot added the Campaign (any) Deprecated tag, replaced with separate tags for each mainline campaign label Feb 19, 2022
stevecotton
stevecotton approved these changes Feb 19, 2022
View reviewed changes
Copy link
Contributor

@stevecotton stevecotton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CI checks are still running, so approving rather than merging immediately.

@CelticMinstrel
Copy link
Member

And now they've passed, so merging.

@CelticMinstrel CelticMinstrel merged commit 35aa0d1 into wesnoth:master Feb 19, 2022
@knyghtmare knyghtmare deleted the wc-update-deprecated-share-view branch February 20, 2022 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevecotton stevecotton stevecotton approved these changes

Assignees
No one assigned
Labels
Campaign (any) Deprecated tag, replaced with separate tags for each mainline campaign
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@knyghtmare @CelticMinstrel @stevecotton