Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SoF: explain the Shorbear tools as products of the volcanic forge #6554

Merged
merged 1 commit into from Mar 9, 2022

Conversation

stevecotton
Copy link
Contributor

I don't like the explanation of the tools being made of unobtainium, so changed
it to use a convenient plot device. I think this also solves a plot hole about
the forge; instead of it being near the Shorbear Caves by random chance, this
gives a reason for the Shorbear Clan to live there (even if they haven't been
in there in living memory).

@max-torch I'd appreciate a review please, but I can't add you in Github's UI.

I don't like the explanation of the tools being made of unobtainium, so changed
it to use a convenient plot device. I think this also solves a plot hole about
the forge; instead of it being near the Shorbear Caves by random chance, this
gives a reason for the Shorbear Clan to live there (even if they haven't been
in there in living memory).
@stevecotton stevecotton added Backport A reminder of a bugfix that was added to master that needs to be duplicated on the stable branch. Campaign (any) Deprecated tag, replaced with separate tags for each mainline campaign Prose Issues with prose text for the game. labels Mar 6, 2022
@stevecotton stevecotton requested a review from nemaara March 6, 2022 15:46
@stevecotton stevecotton self-assigned this Mar 6, 2022
Copy link
Member

@knyghtmare knyghtmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but I can't add you in Github's UI.

Only members can be requested for review. Anyone else has to be mentioned with an @username

I got a question...which might be another wider plothole.

If that volcanic forge originally belonged to the Shorbear Clan and they had been on their clan home in that mountain all this time...shouldn't they have assailed the resident dragon of that cavern. Because a dragon does Roam from their lair to hunt once in a while, so the clan scouts should have spotted the dragon leaving and entering their ancestral forge cave entrance....which would have prompted them to take it back from the Dragon...
So...what's the explanation for that?

@stevecotton
Copy link
Contributor Author

stevecotton commented Mar 6, 2022

So...what's the explanation for that?

That the tools are so ancient that the existence of the forge has been forgotten, possibly UtBS style (some runesmiths know about the forge, but also know some reason to keep that as forbidden knowledge). Needs some magical reason that the tools never become blunt or need repair.

If the "all runesmiths die when Thursagan dies" is still in canon, then maybe the volcano is itself part of the runesmiths' magic? So it would be the destruction of the seal rather than the death of Thursagan himself that kills them all.

@max-torch
Copy link
Contributor

This could explain why there is a forge in the cave for Thursagan to make use of. Possibly the ancient dwarves used it - and then they accidentally dug too deep and woke something they should not have awaken, a balrog, er i meant dragon, which chased them out of the cave.

@stevecotton stevecotton merged commit 1f41893 into wesnoth:master Mar 9, 2022
@@ -300,7 +300,7 @@
[/message]
[message]
speaker=Theganli
message= _ "Well... Maybe you can ask the Shorbear clan? They have good tools... chisels made of some rare mineral. I don’t know what mineral it is or how they got it, but their work is well known among us gem crafters."
message= _ "Well... Maybe you can ask the Shorbear clan? They have good tools... chisels made of a metal that could only be worked in the heat of a volcanic forge. I don’t know how true that legend is, but their work is well known among us gem crafters."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May I suggest this edit. Is it agreeable?

Suggested change
message= _ "Well... Maybe you can ask the Shorbear clan? They have good tools... chisels made of a metal that could only be worked in the heat of a volcanic forge. I don’t know how true that legend is, but their work is well known among us gem crafters."
message= _ "Well... Maybe you can ask the Shorbear clan? They have good tools. According to legend, their chisels are made of a metal that can only be worked in the heat of a volcanic forge. I don’t know if it's actually true, but their work is well known among us gem crafters."

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems a bit too long to me.

The it's should be it’s using the typographic fancy-apostrophe.

You could open a new PR for it - just noticed that there's inconsistent capitalisation of the letters after the ...s , which could be fixed too.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As string-freeze is on Saturday, I'm intending to open a PR for the inconsistent capitalisation fix, unless you want to open a PR for a bigger change.

@max-torch
Copy link
Contributor

I, uh, havent mastered how to review on GitHub. Anyway I clicked "Submit Review" to get rid of the "Pending" tag on the review.

@knyghtmare
Copy link
Member

I, uh, havent mastered how to review on GitHub. Anyway I clicked "Submit Review" to get rid of the "Pending" tag on the review.

The PR was already merged though...

@max-torch
Copy link
Contributor

I, uh, havent mastered how to review on GitHub. Anyway I clicked "Submit Review" to get rid of the "Pending" tag on the review.

The PR was already merged though...

So no one could see what my review was prior to 14 hours ago? .... My rusty GitHub skills...

@stevecotton
Copy link
Contributor Author

So no one could see what my review was prior to 14 hours ago?

Exactly - and then I read the notification from Github on my phone and forgot to respond when I got back to the PC.

@stevecotton stevecotton deleted the sof_volcanic_tools branch December 3, 2022 03:24
@stevecotton
Copy link
Contributor Author

This was backported, but AFAICS there was no PR for the backport (it happened during the text-changes prior to 1.16.3).

@TheShadowOfHassen is now looking at possible further text changes in https://r.wesnoth.org/t57067 , which is why I was searching for another PR with additional comments. That forum thread is probably the place to post anything new.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backport A reminder of a bugfix that was added to master that needs to be duplicated on the stable branch. Campaign (any) Deprecated tag, replaced with separate tags for each mainline campaign Prose Issues with prose text for the game.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants