[1.16] Add unit tests for Lua API wesnoth.simulate_combat #6569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevecotton
added
Unit Tests
stevecotton
commented
Mar 22, 2022
stevecotton
force-pushed
the
test_sim_combat_1_16
branch
from
7918748
to
25992e8
Compare
|
I don't really have anything to say about this. It seems fine. |
|
you don't add in master branch? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building blocks to write the tests that I want to add for #6468. The PR adds the tests to 1.16, because it might as well check that the API stays stable.
@newfrenchy83 sorry it's taking so long to finish your review.