Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.17 terrain transitions update #6588

Merged
merged 5 commits into from Apr 2, 2022

Conversation

doofus-01
Copy link
Member

This is best summarized with these before/after images. Possibly the rubble is too busy now, maybe it should have bigger rocks, or maybe just lower contrasts.
Screenshot_20220327_before
Screenshot_20220327_after

@github-actions github-actions bot added Graphics Issues that involve the graphics engine or assets. Terrain Issues that involve terrain definitions or their implementation in the engine. labels Mar 27, 2022
@stevecotton
Copy link
Contributor

It's beginning to look like a stone path rather than rubble, IMO.

@doofus-01
Copy link
Member Author

It's beginning to look like a stone path rather than rubble, IMO.

That is up to the map designer, I think? In any case, I've made some of the rocks bigger.

I'll merge this in a few days, if there are no objections or CI failures.

@Pentarctagon
Copy link
Member

Having something that could be used for an old/ruined stone isn't a bad thing either.

@stevecotton
Copy link
Contributor

It's beginning to look like a stone path rather than rubble, IMO.

That is up to the map designer, I think? In any case, I've made some of the rocks bigger.

Looks good, thanks. Sorry for commenting without checking these in the editor first, having tested them it's easy to distinguish a line of these from a line of the flat terrains Cobbles or Cave Path.

@doofus-01 doofus-01 marked this pull request as ready for review April 2, 2022 11:11
@doofus-01 doofus-01 merged commit 9f98081 into wesnoth:master Apr 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Graphics Issues that involve the graphics engine or assets. Terrain Issues that involve terrain definitions or their implementation in the engine.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants