Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NR S05a_01 The Pursuit - Fixed units getting stuck in the wall before the spider chamber. #6610

Merged
merged 2 commits into from Apr 5, 2022

Conversation

Descacharrado
Copy link
Contributor

@Descacharrado Descacharrado commented Apr 4, 2022

Stuck units will now be brought back (or pushed forward if hex is occupied). Also fixed the trigger. Will open backport PR soon when approved.

Closes #6607

@github-actions github-actions bot added the Campaign (any) Deprecated tag, replaced with separate tags for each mainline campaign label Apr 4, 2022
@eyalroz
Copy link

eyalroz commented Apr 4, 2022

Why not let them make it in? Do you think that would be too easy? The spider den is kind of a death-trap with only one unit.

@Descacharrado
Copy link
Contributor Author

Why not let them make it in?

I think that is the original idea

Do you think that would be too easy?

No, even with two units it is difficult.

The spider den is kind of a death-trap with only one unit.

True, but it has a tactical use, which remains the same with these changes.

Anyways there is still a way of getting three units inside, it is just a bit harder to do now and no units can be on the wall.

@Descacharrado
Copy link
Contributor Author

Also why did that check fail? Don't think I did anything wrong.

Could not initialise SDL_video error, attempt 1
Could not initialise SDL_video error, attempt 2
Could not initialise SDL_video error, attempt 3
Could not initialise SDL_video error, attempt 4
Could not initialise SDL_video error, attempt 5
Traceback (most recent call last):
  File "./run_wml_tests", line 345, in <module>
    runner.run_tests(batch, test_summary)
  File "./run_wml_tests", line 236, in run_tests
    if res.returncode < 0:
AttributeError: 'NoneType' object has no attribute 'returncode'
Could not initialise SDL_video error, attempt 6
Could not initialise SDL_video error, attempt 7
Could not initialise SDL_video error, attempt 8
Could not initialise SDL_video error, attempt 9
Could not initialise SDL_video error, attempt 10
********** !FAILURE! **********
********** !FAILURE! **********
********** !FAILURE! **********
********** !FAILURE! **********
********** !FAILURE! **********
WML tests failed! (./run_wml_tests -g -c -t 20)

@Pentarctagon
Copy link
Member

Seems like just some random failure, you can ignore it.

@Wedge009 Wedge009 added the Backport A reminder of a bugfix that was added to master that needs to be duplicated on the stable branch. label Apr 4, 2022
@Wedge009
Copy link
Member

Wedge009 commented Apr 5, 2022

Why not let them make it in?

I think that is the original idea

I don't like the design, but yes, I think that was the original intent as well. Maybe one could try to sneak one of the respawning mages through...

Anyway, thanks for resolving this so fast. Tested and seems to resolve the issue, also is approved, so merging. I also tested an extreme case where units lined the entrance to the cave and the units in the wall get teleported appropriately.

I'll back-port after.

@Wedge009 Wedge009 merged commit d4bddb5 into wesnoth:master Apr 5, 2022
@Descacharrado
Copy link
Contributor Author

Descacharrado commented Apr 5, 2022

I'll back-port after.

I have a backport branch ready to PR, dont worry too much about it ill open it soon.

Edit: eh nvm I saw the commit hehe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backport A reminder of a bugfix that was added to master that needs to be duplicated on the stable branch. Campaign (any) Deprecated tag, replaced with separate tags for each mainline campaign
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unit can become co-located with wall in NR Pursuit
5 participants