Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.17 - minor terrain updates #6626

Merged

Conversation

doofus-01
Copy link
Member

@doofus-01 doofus-01 commented Apr 17, 2022

Rrd graphics are mostly placeholder, the graphics rules were the point for now.
Addresses #1345 - not by making , |, / versions, but just futzing with the images.
Screenshot_20220417_
I'm not sure about the road color, but it's really easy to change for now.

@github-actions github-actions bot added Graphics Issues that involve the graphics engine or assets. Terrain Issues that involve terrain definitions or their implementation in the engine. labels Apr 17, 2022
@doofus-01 doofus-01 changed the title 1.17 - minor updates to desert terrain 1.17 - minor terrain updates Apr 18, 2022
@doofus-01
Copy link
Member Author

Screenshot_20220417_b
The bright white snow makes some of the shortcomings of the existing bridges more obvious, will need to be fixed in this PR, at least for ^Bsa*.
The general bridge-to-castle transition scheme also needs work, not sure if this will be fixed here.

@doofus-01 doofus-01 marked this pull request as ready for review April 23, 2022 23:45
@doofus-01
Copy link
Member Author

I think I introduced a bug in #6606 by fixing a bad image reference, and solved it by commenting out a rule that used to always fail, but I may be missing something, so I didn't remove them. It seems to work now, but more testing is always needed.

@doofus-01 doofus-01 merged commit 4e00e30 into wesnoth:master Apr 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Graphics Issues that involve the graphics engine or assets. Terrain Issues that involve terrain definitions or their implementation in the engine.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant