Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.16] SoF S09: A few extra translation hints #6633

Merged
merged 3 commits into from Apr 23, 2022

Conversation

stevecotton
Copy link
Contributor

Also an idea for the translators' changelog: put a paragraph starting with po: in the commit message, so that someone can generate the translators' changelog from the Git changelog.

Example covering this and 2581ab6 / f82079b :

po: In SoF S09, many strings involving Krawg (a gryphon) assumed that Krawg was
the only flying unit. Similar texts have been added that are used when the player
has gryphon riders too; most of these will be marked as fuzzy versions of the
Krawg-only strings.

po: In SoF S09, many strings involving Krawg (a gryphon) assumed that Krawg was
the only flying unit. Similar texts have been added that are used when the player
has gryphon riders too; most of these will be marked as fuzzy versions of the
Krawg-only strings.
@stevecotton stevecotton added Campaign (any) Deprecated tag, replaced with separate tags for each mainline campaign Translations Issues with translations, translation tooling, the translations engine, or code that uses it. Fwdport A reminder of a bugfix that was added to the stable branch that needs to be duplicated on master. labels Apr 22, 2022
@stevecotton stevecotton self-assigned this Apr 22, 2022
@Pentarctagon
Copy link
Member

I guess, is there a benefit to doing it this way rather than regular hints that show up in poedit?

@stevecotton
Copy link
Contributor Author

The idea of putting it in the commit message is that it's useful for a translator who had an up-to-date 1.16.2 file and is looking at the new strings, but would just be excess info for a translator who's starting with a very out-of-date or never-translated file.

@Pentarctagon
Copy link
Member

I'd say this should include the (I assume python) script to do this as well then.

@stevecotton
Copy link
Contributor Author

stevecotton commented Apr 23, 2022

I wasn't planning to automate it, at least not in the near future. The plan is just to pipe the output of git log 1.16.2.. or git log --grep '^po:' 1.16.2.. into a text editor, the same workflow as my "add missing stuff to the changelog" task.

The idea being that it's something that's collated, edited, and sent to the i18n list when the pot-update is done.

@CelticMinstrel
Copy link
Member

I guess, is there a benefit to doing it this way rather than regular hints that show up in poedit?

Well, I would say that his example is extremely unsuitable as a general translation comment:

po: In SoF S09, many strings involving Krawg (a gryphon) assumed that Krawg was
the only flying unit. Similar texts have been added that are used when the player
has gryphon riders too; most of these will be marked as fuzzy versions of the
Krawg-only strings.

This only makes sense if the translator is comparing two versions. It's nonsensical for a generic po file, especially a newly-generated one.

Copy link
Member

@Wedge009 Wedge009 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just remarking on the hints specifically, this seems good to me.

@stevecotton stevecotton merged commit 745a0e1 into wesnoth:1.16 Apr 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Campaign (any) Deprecated tag, replaced with separate tags for each mainline campaign Fwdport A reminder of a bugfix that was added to the stable branch that needs to be duplicated on master. Translations Issues with translations, translation tooling, the translations engine, or code that uses it.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants