Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add decltype. #6646

Merged
merged 2 commits into from Apr 27, 2022
Merged

Add decltype. #6646

merged 2 commits into from Apr 27, 2022

Conversation

Pentarctagon
Copy link
Member

Already ran it on my fork's CI, so merging immediately.

@Pentarctagon Pentarctagon merged commit 5eab237 into wesnoth:master Apr 27, 2022
@github-actions github-actions bot added the UI User interface issues, including both back-end and front-end issues. label Apr 27, 2022
@CelticMinstrel
Copy link
Member

I'm kinda surprised that works, since decltype(evt) looks like it should be known at instantiation time. The ideal solution is probably to use an auto template argument in the definition:

template<auto>
inline constexpr bool dependent_false_v = false;

But I'm not sure if that actually works in C++17, and I'm also not sure if auto can deduce to typename. I think it should work on some version though, so it's something to keep in mind for the future…

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
UI User interface issues, including both back-end and front-end issues.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants