Refactor FindHistory.cmake #6654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Building
* use all lower case keywords for consistency * add target for libhistory: History::History
bencsikandrei
force-pushed
the
refactor_find_history_cmake
branch
from
9457617
to
014cf79
Compare
|
Thanks! And as a heads up if you're going to continue looking at other files, the reason there are some differences between Windows/MSVC for how libraries are added is we use vcpkg for our Windows builds which makes things like SDL2::SDL2 available (which are present otherwise). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
I was super excited to look into
wesnoth! Amazing work!While I was getting to know the project I've read through some of the
cmakefinders and thought I may help with some modernization.I've made
FindHistory.cmakeuse lower caps keywords, added anIMPORTEDtarget for it and some documentation that looks like the standardcmakedocs.Please let me know if this kind of stuff is interesting to you as I'll probably also look into the other
cmakefiles during my journey.Thanks and keep up the great work!
Andrei
EDIT: my editor was configured with
spaces. I noticed all other cmake finders use tabs. I'll update accordingly