Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Have cmake also execute the conftests. #6660

Merged
merged 1 commit into from May 3, 2022
Merged

Have cmake also execute the conftests. #6660

merged 1 commit into from May 3, 2022

Conversation

Pentarctagon
Copy link
Member

This moves the scons conf tests into their own cpp files rather than being embedded in the scons python scripts, and also has them be executed by cmake before building.

@Pentarctagon Pentarctagon marked this pull request as draft April 30, 2022 19:52
@github-actions github-actions bot added Building Build-time issues. CMake Issues involving the CMake build system. SCons Issues involving the SCons build system. labels Apr 30, 2022
@github-actions github-actions bot added the Graphics Issues that involve the graphics engine or assets. label May 1, 2022
@Pentarctagon Pentarctagon force-pushed the ctest branch 5 times, most recently from b226b03 to 16be133 Compare May 3, 2022 14:34
@Pentarctagon Pentarctagon marked this pull request as ready for review May 3, 2022 23:06
@Pentarctagon Pentarctagon merged commit 0aa8dc3 into wesnoth:master May 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Building Build-time issues. CMake Issues involving the CMake build system. Graphics Issues that involve the graphics engine or assets. SCons Issues involving the SCons build system.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@Pentarctagon