Refactor FindTranslationTools.cmake #6667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* macro for avoiding code repetition
github-actions
bot
added
Building
|
Looks good, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
I've looked into the translation search file and it was finding a bunch of
gettexttools in the same manner.Used a macro to factor that code out a bit.
How I've tested: inside a docker container and I've activated the
ENABLE_POT_UPDATE_TARGETand built like that.During my testing I've had cmake in very verbose mode to check for the paths and how it set the variables. All LGTM.
All in all seems to work well and the code is shorter and easier to modify if needed.
The CI seems to also do what I've done so fingers crossed!
Please let me know if you'd like me to further test this change.
Thanks!
Andrei