Refactor find vorbis file cmake #6671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Building
Pentarctagon
reviewed
May 2, 2022
Feel free to try, of course. It's kind of a mess though as the comments around it in the root CMakeLists.txt notes.
I don't have a preference either way. |
bencsikandrei
commented
May 2, 2022
| @@ -36,28 +36,14 @@ http://code.google.com/p/osgaudio/source/browse/trunk/CMakeModules/FindVorbisFil | |||
| set(VORBISFILE_SEARCH_PATHS | |||
| ~/Library/Frameworks | |||
| /Library/Frameworks | |||
| /usr/local | |||
| /usr/local | |||
There was a problem hiding this comment.
spaces -> tabs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A couple of changes for consistency with the other modules + a small commit to state the minimum requirements for Boost and CMake which were a bit behind.
As always, tested as much I could, the
link.txtfile is looking good, same ascompile_commands.json.I was thinking, would it be interesting to move the
FindXXXfiles in acmake/modulesfolder? That way they're separate from other cmake utilities.Also, since I've embarked in this journey, and haven't yet seen the whole history of the project, have there been efforts to unite the SDL2 find? I'm thinking about unifying windows/*nix finders with a couple of tricks but I'd like to see if there have been other efforts. Of course, it's fine even if there weren't and it may actually be impossible, but I'd like to try.
Thanks!