Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.17 waterworld #6695

Merged
merged 12 commits into from
May 22, 2022
Merged

1.17 waterworld #6695

merged 12 commits into from
May 22, 2022

Conversation

doofus-01
Copy link
Member

This was inspired by a semi-recent conversation about underwater scenarios. It doesn't directly address that, but it does lay some groundwork. So far, this has:

  1. Another water creature/monster
  2. Seaweed terrain - I'm not totally sure how to deal with this, for now it is a "swamp" overlay.
  3. Seashells - a simple embellishment overlay

All WIP, especially the seaweed/kelp

@github-actions github-actions bot added Graphics Issues that involve the graphics engine or assets. Terrain Issues that involve terrain definitions or their implementation in the engine. Units Issues that involve unit definitions or their implementation in the engine. labels May 9, 2022
symbol_image=water/seaweed/kelp-tile
id=sea_kelp
name= _ "Swamp"
editor_name= _ "Kelp Forest"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't name and editor_name be the same?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, the editor names seem to be more descriptive. I don't know that "Swamp" is necessarily the right thing here, but at least it is informative of the current situation.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, sure, maybe editor name is more descriptive, but… it doesn't seem correct for it to be completely different as it is in this case.

@stevecotton
Copy link
Contributor

@Pentarctagon should these all be webp instead of png?

@Pentarctagon
Copy link
Member

It depends on if they're smaller or not.

@doofus-01
Copy link
Member Author

Does something like #6697 make it not matter what image type is called anymore? Otherwise, replacing the png with webp needs to be its own little project, unrelated to this.

@Pentarctagon
Copy link
Member

Another issue that came up recently as well, is it turns out that MediaWiki (or at least our version of it) currently doesn't display webp images when linked on the wiki. This would then break https://wiki.wesnoth.org/TerrainCodeTableWML, for example. So further mass conversions to webp will need to wait until that's addressed.

@soliton-
Copy link
Member

You need to append a dummy ?.png to the URL then displaying webp works as well. (https://www.mediawiki.org/wiki/Manual:$wgAllowExternalImages#Why_allow_external_images?)

@doofus-01 doofus-01 marked this pull request as ready for review May 22, 2022 02:53
@doofus-01
Copy link
Member Author

I plan to write a couple higher level Caribe, but not for now. The kelp is supposed to be useful for water expanses; I don't think it adds much for a crowded coast or delta. The other stuff is pretty minor, but hopefully still a small step of progress.

I intend to merge if this passes CI.

@doofus-01 doofus-01 merged commit e2c5712 into wesnoth:master May 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Graphics Issues that involve the graphics engine or assets. Terrain Issues that involve terrain definitions or their implementation in the engine. Units Issues that involve unit definitions or their implementation in the engine.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants