-
-
Notifications
You must be signed in to change notification settings - Fork 995
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1.17 waterworld #6695
1.17 waterworld #6695
Conversation
symbol_image=water/seaweed/kelp-tile | ||
id=sea_kelp | ||
name= _ "Swamp" | ||
editor_name= _ "Kelp Forest" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't name and editor_name be the same?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, the editor names seem to be more descriptive. I don't know that "Swamp" is necessarily the right thing here, but at least it is informative of the current situation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, sure, maybe editor name is more descriptive, but… it doesn't seem correct for it to be completely different as it is in this case.
@Pentarctagon should these all be webp instead of png? |
It depends on if they're smaller or not. |
Does something like #6697 make it not matter what image type is called anymore? Otherwise, replacing the png with webp needs to be its own little project, unrelated to this. |
Another issue that came up recently as well, is it turns out that MediaWiki (or at least our version of it) currently doesn't display webp images when linked on the wiki. This would then break https://wiki.wesnoth.org/TerrainCodeTableWML, for example. So further mass conversions to webp will need to wait until that's addressed. |
You need to append a dummy |
I plan to write a couple higher level Caribe, but not for now. The kelp is supposed to be useful for water expanses; I don't think it adds much for a crowded coast or delta. The other stuff is pretty minor, but hopefully still a small step of progress. I intend to merge if this passes CI. |
This was inspired by a semi-recent conversation about underwater scenarios. It doesn't directly address that, but it does lay some groundwork. So far, this has:
All WIP, especially the seaweed/kelp