Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential fix for flickering and corrupted graphics on master branch. #6727

Merged
merged 1 commit into from May 26, 2022

Conversation

mesilliac
Copy link
Contributor

Changed to render everything to an offscreen texture rather than allowing SDL to do whatever it wants.

This isn't all that undesirable anyway.

From my earlier research, the only thing that doesn't support rendering to texture is some very very old graphics hardware. So likely these days, nothing.

This should fix issues with inconsistent buffering behaviour.
@Wedge009 Wedge009 added the Graphics Issues that involve the graphics engine or assets. label May 25, 2022
@Wedge009
Copy link
Member

I had flickering on Linux/X11 but not Windows (AMD GPUs in both cases). This PR seems to resolve the flickering for me.

@Pentarctagon
Copy link
Member

This seems to fix the flickering for me as well.

@mesilliac mesilliac merged commit 0006c50 into wesnoth:master May 26, 2022
@mesilliac mesilliac deleted the flicker_fix branch May 26, 2022 01:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Graphics Issues that involve the graphics engine or assets.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants