Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Terrains] Snowy Drake Village #6731

Merged
merged 1 commit into from May 31, 2022

Conversation

knyghtmare
Copy link
Member

Originally by the forum user Neil Armius / neilarmius

image

These seem really good to be just lost in the forums, so opening the PR.

Notes on the terrain type code being ^Vka:

  1. ^V must be present for village terrain types
  2. small case a must be present for frozen/snow terrain
  3. k because d is already taken for dry/desert terrain

@knyghtmare knyghtmare added Enhancement Issues that are requests for new features or changes to existing ones. Graphics Issues that involve the graphics engine or assets. Terrain Issues that involve terrain definitions or their implementation in the engine. labels May 28, 2022
@knyghtmare knyghtmare requested a review from doofus-01 May 28, 2022 21:05
Copy link
Member

@doofus-01 doofus-01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The snow looks a little gray, probably too much of the original color bleeding through (it happened to me too with the snowy orc castle). So it might need some touch-ups later, but it basically looks good to me.

@Pentarctagon
Copy link
Member

Were these posted to the Art Contributions forum?

@knyghtmare
Copy link
Member Author

Were these posted to the Art Contributions forum?

Original Post: https://forums.wesnoth.org/viewtopic.php?p=538326#p538326 in the year 2012 (a decade ago)
Started out in two of SkyOne's UMCs. Later on, the terrain tile moved to UMC Terrain Pack and stayed there.

Anyways, I think the author intended it for being added to the core terrain package but I guess nobody had a clear idea how terrain was committed then. I updated the terrain code and terrain transitions to match the current master branch.

@knyghtmare knyghtmare merged commit 4dc2c34 into wesnoth:master May 31, 2022
@knyghtmare knyghtmare deleted the snowy-drake-village-add branch May 31, 2022 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Issues that are requests for new features or changes to existing ones. Graphics Issues that involve the graphics engine or assets. Terrain Issues that involve terrain definitions or their implementation in the engine.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants