Fix wmlindent quote detection #6764
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
AI
soliton-
reviewed
Jun 11, 2022
CelticMinstrel
added a commit
that referenced
this pull request
Jun 18, 2022
* wmlindent: Fix parsing quotes in comments * Remove unnecessary wmlindent ignores * Run wmlindent
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's been a persistent wmlindent warning in the CI logs for awhile now, so I thought I'd fix it. This prevents wmlindent from treating commented-out quotes as opening or closing a string.
I also removed several ignore directives that were clear workarounds for the bug, as well as a clearly-pointless pair in terrain-graphics.cfg. As you can see, there are no actual changes in the wmlindent run as a result, other than the removal of trailing whitespace.