Fix load_string() ignoring the passed chunk name #6794
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Complete with a unit test! The test results in PASS_BY_VICTORY if it fails, which is a bit weird, but it does work.
github-actions
bot
added
Lua API
| [event] | ||
| name=start | ||
| [lua] | ||
| name=test |
There was a problem hiding this comment.
Likely not needed, but I'd prefer the name here be something more unique than just "test".
Pentarctagon
approved these changes
Jun 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Complete with a unit test!
The test results in PASS_BY_VICTORY if it fails, which is a bit weird, but it does work.
There was a comment on this commit noting that it won't work without the events PR (#5663), but I suspect that comment is outdated, so I'm opening this to test the CI.