Draw rectangles as lines for some SDL versions. #6801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This seems to work for me, though it's unfortunate that such a work-around is necessary. Thanks. |
Some versions of SDL aren't very good at drawing rectangles, on some systems. Aimed at fixing wesnoth#6799.
A few places were updated to use this check, including one that turned out to be incorrectly making runtime decisions at compile time.
mesilliac
force-pushed
the
alternate_rectangle_draw
branch
from
9f27712
to
76422ac
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aimed at fixing #6799.
According to the SDL bug linked there this was reported in SDL 2.0.15 and should have been fixed in 2.0.18. So i've set it to draw rectangles as four individual lines when linked against the affected SDL versions.
If the problem crops up again for others, the version check could be extended.
I'm assuming the problem doesn't also occur for lines.