New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1.17 Loyalist sprite updates #6803
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Graphics
Issues that involve the graphics engine or assets.
Units
Issues that involve unit definitions or their implementation in the engine.
labels
Jun 26, 2022
This was supposed to be the general, but since no updates for ~10 years, Vyncyn modified it to suit his era's faction, but yeah...there is something. And here you go, more resource material: https://github.com/Turuk/wesnoth-resources/tree/master/units/loyalists Spearman is there but also is not present in the list. |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating the Loyalist Sprites from this thread:
https://forums.wesnoth.org/viewtopic.php?t=34095
Swordsman attack animation is from:
https://forums.wesnoth.org/viewtopic.php?p=595151#p595151
Some of the old sprites have decent animations, but I'm not going to try to replace all of the existing frames. Defense + attack need to be done to be considered "complete", the idle/death/etc. are nice to have but not strictly needed.
EDIT: This PR got bigger than what I intended when I opened it. I'll cull this list, there will be a followup.
Javelineer - base image to work from exists, not touched yet.General - nothing done yetGrand Marshal - nothing done yetNote to self: Add "Luke Bunday (Amorphous)" to the credits, for the swordsman slashing animation.