Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove WC's custom Pick Your Advancements mod #6807

Merged
merged 2 commits into from Jun 29, 2022
Merged

Remove WC's custom Pick Your Advancements mod #6807

merged 2 commits into from Jun 29, 2022

Conversation

CelticMinstrel
Copy link
Member

No description provided.

@github-actions github-actions bot added the Campaign (any) Deprecated tag, replaced with separate tags for each mainline campaign label Jun 28, 2022
@CelticMinstrel CelticMinstrel marked this pull request as ready for review June 29, 2022 13:10
@CelticMinstrel
Copy link
Member Author

Okay, well, the CI passes, so that's good. Does it look like I missed anything?

@Pentarctagon
Copy link
Member

Pentarctagon commented Jun 29, 2022 •
edited

Looks like thtere's

wesnoth/data/campaigns/World_Conquest/lua/game_mechanics/wocopedia/help.lua

Line 204 in a077235

page.checkbox_use_pya.selected = not not wml.variables["wc2_config_enable_pya"]
and anything attached to that in the help.

@Pentarctagon
Copy link
Member

Looks good to me.

@CelticMinstrel CelticMinstrel merged commit 9ade435 into master Jun 29, 2022
@CelticMinstrel CelticMinstrel deleted the wc_remove_pya branch June 29, 2022 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knyghtmare knyghtmare knyghtmare approved these changes

Assignees
No one assigned
Labels
Campaign (any) Deprecated tag, replaced with separate tags for each mainline campaign
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@CelticMinstrel @Pentarctagon @knyghtmare