Add new [screen_fade] WML action #6864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It takes (for now) the arguments: * red, green, blue = values between 0 and 255 * alpha = value between 0 and 255 * duration = time in ms over which to fade The game display is faded to the given colour over the duration. It will be left with an overlay of that colour and alpha until a screen_fade to 0 alpha is performed.
CelticMinstrel
requested changes
Jul 14, 2022
Co-authored-by: Celtic Minstrel <CelticMinstrel@users.noreply.github.com>
|
Hmm, i applied all the suggested changes but github still says changes are requested. Aside from github's strange hangups, i think this should be ready for squash and merge... |
CelticMinstrel
approved these changes
Jul 15, 2022
|
GitHub requires approval to be set manually. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an implementation of FR #6745 . As mentioned there it is a new interface action WML tag
[screen_fade], which can fade the game display to a given colour over a given duration.It has the following format in WML:
The fade is persistent, so after fading to a colour that colour is kept as an overlay on the game map until a fade to 0 alpha is performed.
I already implemented fading in #6855 so this is just the WML interface.
Unlike the
[color_adjust]tag, this one also covers units and halos. And also unlikecolor_adjust,screen_fadeis hardware accelerated.I also added a flashy event to the test scenario to make sure that it works.