Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1.17 dunefolk falconer portrait #7061

Merged
merged 3 commits into from
Nov 20, 2022
Merged

1.17 dunefolk falconer portrait #7061

merged 3 commits into from
Nov 20, 2022

Conversation

doofus-01
Copy link
Member

No description provided.

@doofus-01 doofus-01 added Graphics Issues that involve the graphics engine or assets. Units Issues that involve unit definitions or their implementation in the engine. labels Oct 24, 2022
@doofus-01 doofus-01 marked this pull request as ready for review October 29, 2022 21:18
@doofus-01
Copy link
Member Author

Ideally, Lordbob would review this, but I don't know if he's still around for this sort of thing. I'll plan to merge this for 1.17.10 if I don't hear from him before then.

knyghtmare
knyghtmare reviewed Nov 2, 2022
View reviewed changes
Copy link
Member

@knyghtmare knyghtmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can the face please be more human-like and less-orclike?

@doofus-01
Copy link
Member Author

I'm open to revisiting this if the portrait director wants, whether that's Lordbob or someone else.

@doofus-01 doofus-01 merged commit 94cc484 into wesnoth:master Nov 20, 2022
bencsikandrei pushed a commit to bencsikandrei/wesnoth that referenced this pull request Nov 21, 2022
@doofus-01 @bencsikandrei
1.17 dunefolk falconer portrait (wesnoth#7061)
7cfdfbf 
* adding dunefolk falconer portrait
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knyghtmare knyghtmare knyghtmare left review comments

@Lordbob Lordbob Awaiting requested review from Lordbob

Assignees
No one assigned
Labels
Graphics Issues that involve the graphics engine or assets. Units Issues that involve unit definitions or their implementation in the engine.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@doofus-01 @knyghtmare