Make undo work again, undeprecate on_event() #7136
Conversation
Fixes wesnoth#6898. The issue is that non-WML events added through the new events API always disable undo with no equivalent of WML's `[allow_undo]`. The long-term fix is to add a way to do that; however until that's available then listeners for `moveto` need to use the old `on_event` API. The old `on_event` API can't be deprecated yet, and this is enforced by our unit tests (the build fails if there are unexpected deprecation warnings during the tests). Reverts most of 7e234f8. Does not revert files that only listen for non-undoable events such as `die` or `new turn`. Reverts the deprecation part of wesnoth#5663's 8cd1332.
stevecotton
added
Bug
github-actions
bot
added
Lua API
|
Reverting (most of) 7e234f8 I get, as that was my recommended quick fix for this, but why revert the deprecation too? There shouldn't be anything wrong with continuing to use things that are deprecated. EDIT: After posting I noticed the detail on your commit message that explains this. Well… it's not the end of the world to leave it not deprecated for the time being, so whatever. |
|
There should be an issue opened to keep track of the missing undo functionality from the new API, even if #6898 is closed, since even though this fixes it in mainline UMC will start running into this as well. |
|
Would be great to get this merged ASAP. Having a major game feature broken for this long is pretty bad even if it's a dev version. |
|
@CelticMinstrel I'm assuming your "it's not the end of the world" is an approval, will merge this evening unless you say otherwise. |
|
It's not an approval so much as a lack of disapproval? But close enough, I guess. |
Fixes #6898. The issue is that non-WML events added through the new events API always disable undo with no equivalent of WML's
[allow_undo]. The long-term fix is to add a way to do that; however until that's available then listeners formovetoneed to use the oldon_eventAPI. The oldon_eventAPI can't be deprecated yet, and this is enforced by our unit tests (the build fails if there are unexpected deprecation warnings during the tests).Reverts most of 7e234f8. Does not revert files that only listen for non-undoable events such as
dieornew turn.Reverts the deprecation part of #5663's 8cd1332.