Adding/Changing Unit Descriptions

[Gothyoba]

This PR aims to add unit descriptions to Wesnoth units, or replace unit descriptions which have been copied from other units. More units can be worked on, and changes can be made to these new descriptions. This is intended to make the game feel deeper, more complete and implement more lore around these units. The following units have been worked on in this PR:

Direwolf - This one had the same description as a wolf. I took some lines from the description for the Direwolf Rider.

Great Wolf - Like the Direwolf, this unit copied its description from the wolf.

Wyvern Rider - This one had no description.

You may suggest changes to these descriptions. While my Great Wolf description does not expand much on the game, I feel like not much can be done there. Adding this description could still make wolves feel more complete though. I am also expanding on Direwolf lore through the Direwolf Rider. I would personally consider this PR to be complete. Is this currently eligible for merging?

Note: I will not be working on Wose Sapling in this PR

[TheShadowOfHassen]

So in the great wolves the sentence "A single one may be kill a soldier as easily as whole pack if found unprepared."

Isn't 100% clear. I understand where you're going. (A single wolf can kill a soldier) but I think it needs another editing pass.

[knyghtmare]

I reviewed your corrections but I just left one unresolved since I am not sure about the dire-wolves being held in high regard by orcs topic.

[Gothyoba]

I have changed a few things here. Orcs still revere the direwolves, yet only goblins may form strong bonds with them. I think this should make sense, as orcs and goblins live in the same society.

[Gothyoba]

So I was thinking about this and maybe the direwolves are specifically revered among the the goblin’s social circles, as this would probably a rather segreagted society. Perhaps instead of symbolizing orcish perseverance, it symbolizes the greatness a goblin can have despite not being born an orc. In response, I might change the descriptions to allow for this new lore. I would appreciate any feedback on this. I’m making this a draft while I’m doing this.

[Gothyoba]

A few changes have been made and this should be ready for review now.

[Gothyoba]

This is now a draft again, as I think the Wyvern Rider should be discussed further. Here is a forum post I made on the topic:

https://forums.wesnoth.org/viewtopic.php?t=56975

[Gothyoba]

It has been five days since I openned the forum post on the Wyvern Rider description. One person answered and the problems they pointed out have been adressed. With all my checks complete, and this being in probably being generally in line with Wesnoth’s standards, this should be ready for review, and perhaps, eventually, merging.

@nemaara Should my proposed Great Wolf description be removed? It does not hold up to your standards, though I find it hard for it to do so. I could (like I did for the Wose Sapling) open an issue for it if it is to be removed.

Thank you to nemaara, knyghtmare, vyncyn, beetlenaut and TheShadowOfHassen for commenting on my ideas here and providing corrections, ideas and feedback on this topic.

Update: In response to suggestions on the Wyvern Rider description I am making this PR a draft again. If you want to comment on these proposals, I suggest you go here: https://forums.wesnoth.org/viewtopic.php?t=56975

[nemaara]

I think the concepts in the Direwolf Rider description is good. For the Wyvern Rider, I think it's better if I spend some time coming up with the concept, since I wrote the description for the rest of the faction. Alternatively, you can try again with a different concept. I just don't think the current one works, the rest of the faction's vibe is about science and reason so I don't really want to have one where they're "revering" Wyverns + their riders. I also don't really like the Great Wolf description so let's table that one.

I'll help you on the wording later once this is not a draft.

[Gothyoba]

Thank you for your feedback.

On the Wyvern Rider:

Personally, I think that with some modification, this description could work. However, perhaps oher ideas could still be better in their place. I recomend reaching concensus in this forum post and removing the Wyvern from this PR: https://forums.wesnoth.org/viewtopic.php?t=56975.

On the Great Wolf:

I think I will give this one another revision. Looking at the description proposed, it not only lacks any expansion on lore, but it does not sound akin to other descriptions in Wesnoth. I think I might experiment with making Great Wolves pack leaders, and talking about their role or strength in wolf society, ot maybe how others see them.

On the Direwolf and Driewolf Rider:

I dont think I will make many major chages here.

Overall:

This PR will likely as a draft, and at least temporarily remving the Wyvern Rider.

[sevu]

@Gothyoba @nemaara If this should be part of the next release, it needs to be merged within the next weeks.

[nemaara]

Okay I added some descriptions in 2375d5f. Make a new PR if you want to try the other ones besides the wolves.

[CelticMinstrel]

That commit doesn't have any unit description changes.

[soliton-]

The commit is ec5bb96.