Post-Freeze Typography Review

[Wedge009]

Extends #7964 - not basing this directly on master because when that one gets merged, this will probably result in merge conflicts otherwise.

I just focused on dashes, apostrophes/quotes, and spacing here. The straight-to-curly quote review was wider this time around - I have seen the micro-AI lines come up in searches before, but previously decided to leave them since they don't look like something average players would see. But since they keep coming up in searches I went ahead and changed them this time around.

I don't expect this to be merged very quickly given the current string freeze.

[stevecotton]

I don't expect this to be merged very quickly given the current string freeze.

Can you confirm that you mean "not into 1.18.x at all"? Otherwise we'd be repeating the event that (rightly IMO) angered Demario.

[Wedge009]

I cannot confirm anything. But if that's the approach we want to take, why bother changing anything?

[Wedge009]

BTW, these are no different from changes done in smaller, more incremental batches. I would argue that it would be better for people to submit correctly presented strings in the first place, if you're concerned about 'angering' people.

That's part of why I tried to make a thorough review of the rewritten Eastern Invasion strings before it got merged, but then that approach seems to 'anger' a different group of people. Cannot make any progress with the approach of avoiding 'angering' people.

[nemaara]

I don't have any comments about translations. That will have to be worked out with translators sometime.

[stevecotton]

With the string freeze postponed, so this is no longer "post-freeze", I retract my objection.

[Pentarctagon]

So, this and #7964 can be merged now, correct?

[Wedge009]

I don't plan any further changes, it's really only pending others' reviews. Given the postponement of the freeze, I understand they're ready to merge.

Then steve can update the Sun Singer text, etc.

[demario-w]

I will not develop how stupid are this "fixes" that refer to a "standard" that obviously only one single developer care to follow.

You must run the po update as soon a possible so that the changes enter the pofiles and are available to translators in isolation.

[Pentarctagon]

Done in 1c51bd3