Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a bunch of tests for heals. #8074

Merged
merged 6 commits into from
Nov 30, 2023
Merged

Conversation

Pentarctagon
Copy link
Member

Covers only attributes, not filters.

@github-actions github-actions bot added the Unit Tests Issues involving Wesnoth's unit test suite. label Nov 27, 2023
Covers only attributes, not filters.
@newfrenchy83
Copy link
Contributor

I don't know why, but include a number in name of abilities don't accepted in shema validation

@newfrenchy83
Copy link
Contributor

newfrenchy83 commented Nov 27, 2023

for validate Ubuntu check you shud change shema/units/abilities.cfg line 15 to
{SIMPLE_KEY name string}

@Pentarctagon
Copy link
Member Author

It being translatable is correct. There's just no reason to ever translate the strings in unit tests.

@newfrenchy83
Copy link
Contributor

And now it's tesring who fail

@Pentarctagon
Copy link
Member Author

It looks like SCHEMA_VALIDATION is defined somehow for those tests.

@stevecotton stevecotton merged commit 87ed0d0 into wesnoth:master Nov 30, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Schema Unit Tests Issues involving Wesnoth's unit test suite.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants