Add submerge to oasis terrain #8812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follow up to wesnoth#8783 this makes a unit on an oasis tile visibly sink slightly into its waters, just like with ford terrain.
github-actions
bot
added
the
Terrain
|
I really think the oasis terrain tile can be improved in appearance to better accompany the terrain type change (I saw it was shallow water and desert now) and also the submerge visual effect. |
|
It's only shallow water. Desert is just the default base as before. |
|
Looks good to me, but I guess @doofus-01 should approve this. |
|
Given that oasis is now (sort of) shallow water, and shallow water is 0.4 and ford is 0.3, 0.3 seems reasonable. Maybe 0.2 would work too, but I haven't tested either one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #8783 this makes a unit on an oasis tile visibly sink slightly into its waters, just like with ford terrain.