Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NR05a: Vary dialogue to better suit the speaker #8830

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Ethan-Nowa
Copy link

I changed some of the lines in NR The Pursuit to fit better with the different heroes. Tallin, Abhai, Krash. I did not do it for every dialogue.
Addresses issues #8319 and #8772

I changed some of the lines in NR The Pursuit to fit better with the different characters. Tallin, Abhai, Krash, etc.
I did not do it for every dialogue.
Addresses issues wesnoth#8319 and wesnoth#8772
@github-actions github-actions bot added the Campaign NR The mainline Northern Rebirth campaign label May 1, 2024
@Wedge009 Wedge009 added the Prose Issues with prose text for the game. label May 1, 2024
@Wedge009 Wedge009 requested a review from nemaara May 1, 2024 04:56
@Wedge009
Copy link
Member

Wedge009 commented May 1, 2024

Thank you for this! I just had a quick look, Abhai sounds in-character to me.

I suppose with the new strings this can only go to master.

@Wedge009
Copy link
Member

Wedge009 commented May 1, 2024

I can't see why the WML check is failing, though.

@CelticMinstrel CelticMinstrel changed the title Update 05a_01_The_Pursuit.cfg NR05a: Vary dialogue to better suit the speaker May 1, 2024
@CelticMinstrel
Copy link
Member

I tried improving the title, feel free to tweak it further though.

[then]
[message]
speaker=Abhai
message= _ "Ah... I had forgotten about this beast."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Abhai can't trigger this event, because the player only finds him once they've reached the other side of this lake.

Copy link
Author

@Ethan-Nowa Ethan-Nowa May 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you have a unit with high enough mp you can move straight to Abhai's home and avoid the event. Then when you move Abhai he can trigger it. I did this unintentionally on my first playthrough of this mission.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm - another option would be to use an [event]name=enter_hex or [event]name=exit_hex with [cancel_action] to make the unit stop when they enter the water. That would have the advantage of showing the tentacles first, instead of letting the unit get stuck in the village with the tentacles attacking them - although with Abhai around I guess the tentacles aren't a threat.

@@ -2090,28 +2160,42 @@

[message]
speaker=unit
message= _ "AH! A ghost!"
message= _ "AH! Ghost!"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer the original here

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed it to that because Krash might trigger it and I thought he's more likely to say just "Ghost!" and not "A ghost!" So that seemed more universal to me.

[then]
[message]
speaker="Krash"
message= _ "Body. Stinks."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While this line is understandable when reading the WML, where we know what triggered it and what the normal unit's line is, it doesn't seem so understandable out of context. If a player is moving a group of units up this river, a sudden "Body. Stinks." is a question of what body? Has it triggered because of the hex, or is Krash saying that his own body is decomposing - should the player prepare for the drake to turn into an enemy undead?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed it to "Corpse... Stinks." I would like to keep it in line with Krash's way of talking (choppy, blunt, few words) but that makes it hard to include the details.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seeing this as "Krash's way of speaking" makes me think that someone went a little overboard at making him a man of few words. I think you could add up to 7 more words and still qualify as "choppy, blunt, and few words". Not that you'd need to for this particular case – 3-4 words is probably perfectly sufficient to get across a meaning roughly equivalent to the more verbose one.

I think at least adding the word "here" somewhere should help.

[else]
[message]
speaker=unit
message= _ "Gee, what’s with these bodies floating around? Is this river some sort of body disposal?"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a meaning here that's lost in Abhai and Krash's lines - that the corpses are drifting down from Malifor's throneroom.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. I'll update them. I thought the bodies were because of the nearby nagas, since I figured Malifor would have used the bodies for undead.

[if]
[variable]
name=unit.id
equals="Tallin"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CI is complaining about tabs instead of spaces here

[then]
[message]
speaker="Krash"
message= _ "Wet."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of these could do with notes to translators

I suggest adding this line above the message:

# po: Krash has landed in one of the hexes of a small underground lake

[then]
[message]
speaker=Abhai
message= _ "Another body... I've noticed them drifting down the river as of late."
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just noticed I've needs a typographic apostrophe.

speaker=Tallin
message= _ "I am Tallin."
[/message]
[/then]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The last commit introduced an extra level of indentation here, it should be removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Campaign NR The mainline Northern Rebirth campaign Prose Issues with prose text for the game.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants