'value' attribute in [experimental_filter_ability(_active)] can have 'default' value #8893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Units
|
@stevecotton could you review this PR, please? It remain 1 or 2 modification after this PR before what experimental_ can be removed. |
soliton-
requested changes
May 22, 2024
newfrenchy83
force-pushed
the
add_default_value_in_filter_ability
branch
3 times, most recently
from
30b033c
to
0dce3b7
Compare
soliton-
reviewed
May 23, 2024
soliton-
approved these changes
May 23, 2024
newfrenchy83
force-pushed
the
add_default_value_in_filter_ability
branch
from
0dce3b7
to
90f0289
Compare
soliton-
approved these changes
May 24, 2024
|
@stevecotton could you merge this PR approved by @soliton- , please? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for answer to an suggestion of @soliton- who think in filter abilitie, value must could check 'default' value of an abilitie/specials directly without have specify this value in filter