-
-
Notifications
You must be signed in to change notification settings - Fork 993
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improve tooltip placement on rh panel #8908
Open
white-haired-uncle
wants to merge
4
commits into
wesnoth:master
Choose a base branch
from
white-haired-uncle:whu-tooltips
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
7b2d1af
improve tooltip placement on rh panel
white-haired-uncle 6e935ff
improve tooltip placement on rh panel
white-haired-uncle cbc47f0
improve tooltip placement on rh panel
white-haired-uncle f088260
improve tooltip placement on rh panel
white-haired-uncle File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -104,6 +104,11 @@ rect floating_label::get_bg_rect(const rect& text_rect) const | |
}; | ||
} | ||
|
||
void floating_label::clear_texture() | ||
{ | ||
tex_.reset(); | ||
} | ||
|
||
bool floating_label::create_texture() | ||
{ | ||
if(video::headless()) { | ||
|
@@ -180,7 +185,7 @@ void floating_label::update(int time) | |
// Invalidate new draw loc in preparation | ||
draw_manager::invalidate_region(get_bg_rect(draw_loc)); | ||
|
||
DBG_FT << "updating floating label from " << screen_loc_ << " to " << draw_loc; | ||
// DBG_FT << "updating floating label from " << screen_loc_ << " to " << draw_loc; | ||
|
||
screen_loc_ = draw_loc; | ||
alpha_ = new_alpha; | ||
|
@@ -206,7 +211,7 @@ void floating_label::draw() | |
return; | ||
} | ||
|
||
DBG_FT << "drawing floating label to " << screen_loc_; | ||
// DBG_FT << "drawing floating label to " << screen_loc_; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Unnecessary commented out code. |
||
|
||
// Clip if appropriate. | ||
auto clipper = draw::reduce_clip(clip_rect_); | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why did you comment this out? If you don't need it, just remove it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh. I commented those out because they were spewing 60 messages each every second to the log I was trying to watch, and I just forgot to put them back. Actually, I suspect someone else just forgot to remove them when they were no longer needed so they should probably be removed, but I'm hesitant to do since I'm not sure. I can uncomment them or remove them. ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Uncomment them, since they are also uncommented in master.