Fixed bug #21486: Team label clears a non-team label #94
Conversation
Editing a non-team label to be a team label no longer removes the old label (ie, everyone not in that team can still see it). https://gna.org/bugs/index.php?21486 Signed-off-by: hp <sachith500@ubuntu.(none)>
|
Just a quick question about this -- what is the issue here? You don't want that Team A can get information even about the locations of Team B's private labels? |
|
Team labels can be used to clear non-team labels on the map. For example, if we're playing a game that requires borders be set up (due to NAPs etc, in modes like conquest), you might have non-team labels saying "Border", but for your team (or yourself alone), you might have the need to place a team label on that spot without removing the non-team (global) label. I picked this up from the bug tracker (I wasn't the one who submitted the ticket). |
|
Are you listed in data/core/about.cfg? Otherwise, this looks good to go. |
|
Yeah, I'll add them and update this PR |
Added changelog entries and updated about.cfg
changelog. Signed-off-by: Sachith Hasaranga Seneviratne <sachith500@gmail.com>
|
OK, done. Btw, I had to send an additional commit to fix a typo in the previous one. If you want me to rebase and send a new PR, let me know. |
|
yeah :P |
Editing a non-team label to be a team label no longer removes the old label (ie, everyone not in that team can still see it).
https://gna.org/bugs/index.php?21486
Signed-off-by: Sachith Hasaranga Seneviratne sachith500@gmail.com