Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardising the front matter #115

Closed
thomasgohard opened this issue Nov 4, 2013 · 11 comments
Closed

Standardising the front matter #115

thomasgohard opened this issue Nov 4, 2013 · 11 comments

Comments

@thomasgohard
Copy link
Member

Right now we have front matter in both JSON and YAML. We should chose one.

I have no preference either way, although I'm more familiar with JSON.

What's the preferred format?

@masterbee
Copy link
Member

@thomasgohard , JSON please since most of the templates variables are being passed as JSON variables.

@thomasgohard
Copy link
Member Author

@masterbee PR #116 is in, with JSON.

@nschonni
Copy link
Member

nschonni commented Nov 4, 2013

Core WET is all YAML for front matter

@thomasgohard
Copy link
Member Author

@nschonni Do we need both repos to be standardised on the same? I think it's fine to have one repo using YAML and one using JSON. As long as, within the same repo, all files are using the same language.

@nschonni
Copy link
Member

nschonni commented Nov 4, 2013

Yup, just pointing it out

@pjackson28
Copy link
Member

@nschonni @thomasgohard We should pick one for both to make it much easier to sustain (and so we have built-in examples). I personally don't have a preference between YAML or JSON so whichever is the better one to support is the one we should go with.

@thomasgohard
Copy link
Member Author

@pjackson28 How about standardising on JSON then?

I think more people will already be familiar with it. I know that @fbernard2 and I spent a lot of time trying to figure how to code certain data structures in YAML that I could have coded in JSON easily.

@pjackson28
Copy link
Member

@thomasgohard Sounds like a good justification for JSON then. We need solutions fast so if JSON can be done much quicker and more people can support it then it seems like the right way to go. Could you please update core with the JSON solution you come up with so we have consistency across repos? This will be important as the GCWeb theme is going to fall under wet-boew soon.

@masterbee
Copy link
Member

@thomasgohard , @nschonni , @pjackson28. I vote for JSON since less indenting ( like Coffeescript ) and more about syntax. Also plugins like tables use it in the data-wet-blew attribute, so I would keep it the same all over.

Just my 2 cents.

@thomasgohard
Copy link
Member Author

OK. I'll update wet-boew to JSON tomorrow.

@thomasgohard
Copy link
Member Author

Standardisation of front matter to JSON for wet-boew is done: wet-boew/wet-boew#3428.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants