-
Notifications
You must be signed in to change notification settings - Fork 660
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Main menu large view - Use light grey to separate menu items (From HE) #4919
Milestone
Comments
rubinahaddad
changed the title
Main menu large view - display issue 5 (From HE)
Main menu large view - Use light grey to separate menu items (From HE)
Mar 19, 2014
pjackson28
pushed a commit
that referenced
this issue
Mar 20, 2014
WET theme: Changed lines separating menu bar links to grey (fixes #4919)
Fixed by changing the separator lines to grey. |
pjackson28
pushed a commit
that referenced
this issue
Mar 20, 2014
GCWU and Intranet themes: Changed lines separating menu bar links to grey (fixes #4919)
pjackson28
pushed a commit
that referenced
this issue
Mar 20, 2014
All themes: Changed lines separating menu bar links to grey (fixes #4919)
pjackson28
pushed a commit
to wet-boew/theme-gcwu-fegc
that referenced
this issue
Mar 20, 2014
Changed lines separating menu bar links to grey (fixes wet-boew/wet-boew#4919)
pjackson28
pushed a commit
to wet-boew/theme-gc-intranet
that referenced
this issue
Mar 20, 2014
Changed lines separating menu bar links to grey (fixes wet-boew/wet-boew#4919)
pjackson28
pushed a commit
to wet-boew/theme-ogpl
that referenced
this issue
Mar 20, 2014
Changed lines separating menu bar links to grey (fixes wet-boew/wet-boew#4919)
pjackson28
pushed a commit
to wet-boew/theme-base
that referenced
this issue
Mar 20, 2014
Changed lines separating menu bar links to grey (fixes wet-boew/wet-boew#4919)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
From HE: wet-boew/wet-boew-styleguide#15
For the WET menu
Recommendation: Use a light grey hairline to separate the menu items instead of dark blue
On the examples page a dark blue divider line is used to show the left edge of the clickable area for the “WET project” menu button. The Canada.ca site uses a light grey hairline that separates and defines the edges of the buttons. The light grey line is a better implementation as the contrast of the dark blue divider on a dark blue button bar background is not sufficient. The “Contribute to WET” menu button is also missing the dark blue divider line on the right side that should be there to indicate the edge of the clickable area. (Bug or missing in code?)
The text was updated successfully, but these errors were encountered: