-
Notifications
You must be signed in to change notification settings - Fork 662
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Placement of showing x to x of x entries - tables #5215
Comments
@rubinahaddad Where would it go? We already have the show entries in the upper left and the filter items in the upper right. It will get quite crowded and busy to cram another thing up there. Also is it a good idea to put the showing x to x at the top while the next/previous are at the bottom? Shouldn't they be together? |
I saw the pattern of the table pagination to work very similar to that of the search results pattern, and in that pattern it’s at the top and not the bottom for similar reasons. |
So is the suggestion to have all four elements at the top stacked in two rows? How is that supposed to look? Could that get to busy with so many elements in advance of the table? |
@pjackson28 Above is what i was thinking... so on smaller views the filter will wrap. |
It is possible to change the order of the markup using the following initialization parameter As for the pagination, @thomasgohard was looking into whether it was a good idea to have the same pagination widget used for tables and pages. |
@pjackson28 Ideally when the "Show X entries" and filter section do not fit on one line it will align-left instead of right |
Fix is in PR #5360 |
Tables: Moved showing x to x of x entries to the top of the table (fixes #5215)
Fix has been merged in. |
@pjackson28 Thanks! Could you plz remove the font-weight on the "Show entries", and "Filter items" to keep it balanced because the "Showing" as no weight? |
@rubinahaddad All form field labels are bolded in every other case so wouldn't it be better to bold showing instead? Also looks a little odd for them to not be bolded but the table header cells right below are bolded. |
@pjackson28 I recommend not bolding the show and filter labels because they are all secondary to the table headings. The table headings should stand out because the data is what the user is after. If you bold all the labels above the table you take away the focus on the headings and the data. |
@rubinahaddad Okay, we can always change it back if it doesn't work out. Fixed in PR #5383. |
Tables: Removed bolding from show and filter fields and updated example source code (fixes #5215)
From HE: wet-boew/wet-boew-styleguide#12
On default could we display “Showing x to x of x entries” at the top of the table instead of the bottom. This helps the user see how many entries they have the option of going through, and it helps them decide if they want to refine.
The text was updated successfully, but these errors were encountered: