Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tables: Moved showing x to x of x entries to the top of the table (fixes #5215) #5360

Merged
merged 1 commit into from
May 2, 2014
Merged

Tables: Moved showing x to x of x entries to the top of the table (fixes #5215) #5360

merged 1 commit into from
May 2, 2014

Conversation

pjackson28
Copy link
Member

No description provided.

@nschonni
Copy link
Member

nschonni commented May 1, 2014

You'll need to add the new files to the SCSSLint exception here https://github.com/wet-boew/wet-boew/blob/master/.scss-lint.yml#L30 because of the DataTables naming

@pjackson28
Copy link
Member Author

Done, thanks!

@@ -28,6 +28,9 @@ linters:
- "src/plugins/geomap/_ie8.scss"
- "src/plugins/geomap/_print.scss"
- "src/plugins/tables/_base.scss"
- "src/plugins/tables/_screen-sm-max.scss"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use spaces. Unfortunately the yaml seems to require them.
Something should be added to https://github.com/wet-boew/wet-boew/blob/master/.editorconfig to catch that

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

pjackson28 pushed a commit that referenced this pull request May 2, 2014
Tables: Moved showing x to x of x entries to the top of the table (fixes #5215)
@pjackson28 pjackson28 merged commit 227c68d into wet-boew:master May 2, 2014
@pjackson28 pjackson28 deleted the datatablesshowing branch May 2, 2014 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants