Bower to npm #8147

nschonni · 2017-09-15T08:23:55Z

Related to #8063 but there are a few left over that will take some more effort.

They don't have official NPM packages:

Flot
excanvas
SideBySideImproved

There is a fork/commit being used:

magnific-popup
openlayers

This could land as-is, but probably needs a good review to see it I overlooked anything when repointing stuff.

There is also a few dependies that are just dropped, since they were orphans from the v4 alpha stage

LaurentGoderre · 2017-09-18T12:42:12Z

@nschonni can you also remove the lock file. Since we fix the node issue we shouldn't pin everything back like that

nschonni · 2017-09-18T16:14:52Z

@LaurentGoderre the NPM 5 lock file is a little different in that it actually works 😉
I could remove it, but since we have a bunch of pinned dependencies, I think it makes sense to leave it until everything can move to a ^ dependency

LaurentGoderre · 2017-09-18T17:23:37Z

Ok!

duboisp · 2017-10-12T14:25:33Z

@nschonni can you fix the Conflicting file

Thanks

nschonni · 2017-11-23T15:44:25Z

Gruntfile.coffee

@@ -1063,7 +1082,7 @@ module.exports = (grunt) ->
 					flatten: true
 				,
 					cwd: "lib/MathJax"
-					src: [
+							src: [


Oops, need to fix whitespace in this file again since I think the MathJax added that accidentally

Since we can’t have multiple versions for 1.x and 2.x in the package.json, the legacy 1.x is handled by downloading it into the old location with wget. Fixed the server message template not using the correct version mmend

Let it bump up since the only difference was compatibility for module loading

No compatible NPM published version, and it has no references in the codebase

This is bundled with Mondernizr for < IE9 and isn’t referenced

Was previously unreferenced and is replaced with the HTML5shiv in Modernizr

Left pinned to the old/existing version

This also moves it to the Official fork under the Google GH org instead of an independent mirror

Kept it pinned at the old/outdated version

Left pinned at the existing version

nschonni · 2017-12-01T01:42:15Z

This has been updated to include the MathJax changes and Magnific

lucas-hay · 2017-12-01T18:33:34Z

@nschonni is this ready to merge now?

nschonni · 2017-12-01T18:41:40Z

Yes

lucas-hay · 2017-12-01T18:59:12Z

@LaurentGoderre are you OK with this being merged?

LaurentGoderre · 2017-12-01T19:01:26Z

bower.json

-    "selectivizr": "1.0.2",
-    "SideBySideImproved": "https://github.com/pkoltermann/SideBySideImproved.git",
-    "unorm": "^1.4.1"
+    "SideBySideImproved": "https://github.com/pkoltermann/SideBySideImproved.git"


Why can't these two go in the package.json?

NPM can only use a Git source if the repo has a package.json in the repo. Those currently don't

Well openlayers we kind of control so you can create a PR there for a package.json

Yeah, there is the separate PR to try and update OpenLayers, so I didn't want to cause more conflicts. I think newer version of the library are just published normally to NPM

OpenLayers is coming via NPM now in the latest PR.

LaurentGoderre · 2017-12-02T18:23:57Z

bower.json

@@ -22,27 +22,12 @@
    "lib"
  ],
  "dependencies": {
-    "bootstrap-sass-official": "3.3.1",
-    "DataTables": "1.10.13",
-    "es5-shim": "2.3.0",
    "excanvas": "*",


We can fork this one and add a package.json. We wont need this in the future of WET so we're just keeping it to not breaking existing things.

Yup, but that can be done then updated in a separate PR

nschonni · 2017-12-05T00:16:14Z

@LaurentGoderre do you want to land this?

duboisp · 2017-12-05T00:21:31Z

@lucas-hay see @nschonni comments

LaurentGoderre · 2017-12-05T13:09:08Z

I don't have time to test irt but if you're confident, I don't see why not!

LaurentGoderre · 2017-12-05T13:10:01Z

@nschonni do you want a squash? I think we should merge multiple commits for this one.

nschonni · 2017-12-05T18:28:26Z

No, I rebased it so each of the commits is pretty atomic, so I don't think the squash is needed

duboisp · 2017-12-05T20:36:06Z

@lucas-hay I think this is the PR that are currently breaking the GCWeb build.

@nschonni @LaurentGoderre can this PR be reverted for now and be merge at the next PR review meeting?

lucas-hay · 2017-12-05T20:41:17Z

@nschonni @LaurentGoderre Can this be fixed in GCWEB or reverted here?
I will finally be releasing 4.0.27 tomorrow and my schedule can't afford any delays tomorrow. I would assume that perhaps the other repo's may have the same problem.

EricDunsworth · 2017-12-05T20:59:43Z

@lucas-hay @duboisp I haven't tested this myself, but wet-boew/GCWeb#1320's Travis-CI error can probably be resolved by porting one of this PR's Gruntfile changes into GCWeb's Gruntfile.

I could send over a GCWeb PR with that change if needed. But I don't have time to test it locally and thus can't guarantee that there won't be any further errors past that point in the build process.

lucas-hay · 2017-12-05T21:04:46Z

@EricDunsworth We would likely need to do this with all repos and with the release tomorrow I think the best bet is to revert for now and we can merge after release is complete and then check other repos.

EricDunsworth · 2018-01-08T22:00:02Z

@duboisp @lucas-hay Are there any plans to re-implement this PR's changes (since #8228 reverted it)?

I personally would've preferred quick-fixing the other themes rather than reverting this PR. The changes it brought in were valid and didn't break this repo's build system.

IMO it would've been more ideal to fix the other themes' build systems - even if it resulted in 4.0.27 getting further delayed. Plus in the end, due to other issues, 4.0.27 didn't end up getting released until over a week after #8228 was merged in.

duboisp · 2018-01-09T00:23:43Z

@EricDunsworth The first thing will be to have all those PR's ready to be merge. Then, after testing, we would be able to merge it and re-apply the change from this PR.

Feel free to submit all those related PR's then it can be merged all at once during a "PR review" meeting.

LaurentGoderre · 2018-01-09T13:37:22Z

Testing this can't be done online btw. You would have to run a local npm link

nschonni force-pushed the bower-to-npm branch from 5570c55 to e9637a9 Compare September 15, 2017 08:32

nschonni force-pushed the bower-to-npm branch from e9637a9 to d0bf0f6 Compare October 13, 2017 01:53

Build: bootstrap-sass move from Bower to NPM

365e1c8

nschonni force-pushed the bower-to-npm branch from 38689cc to b858cca Compare November 23, 2017 15:42

nschonni commented Nov 23, 2017

View reviewed changes

nschonni added 12 commits November 23, 2017 11:21

build: Move jQuery from Bower to NPM

a7aea32

Since we can’t have multiple versions for 1.x and 2.x in the package.json, the legacy 1.x is handled by downloading it into the old location with wget. Fixed the server message template not using the correct version mmend

build: Move jQuery-validation from Bower to NPM

6d4445c

build: Move html5shiv from Bower to NPM

3df9223

Let it bump up since the only difference was compatibility for module loading

build: Drop jquery-pjax dependency

4da4e40

No compatible NPM published version, and it has no references in the codebase

build: Drop respond dependency

e3834d3

This is bundled with Mondernizr for < IE9 and isn’t referenced

build: Drop selectivizr dependency

fa1db66

Was previously unreferenced and is replaced with the HTML5shiv in Modernizr

build: Move proj4 from Bower to NPM

2430ccf

Left pinned to the old/existing version

build: Move google-code-prettify from Bower to NPM

f936323

This also moves it to the Official fork under the Google GH org instead of an independent mirror

build: Move es5-shim from Bower to NPM

b05199c

Kept it pinned at the old/outdated version

build: Move unorm from Bower to NPM

4924162

build: Move DataTables from Bower to NPM

6afbe9d

Left pinned at the existing version

chore: rebuild cache for node-sass

bfb0813

nschonni force-pushed the bower-to-npm branch from b858cca to bfb0813 Compare November 23, 2017 16:22

nschonni added 2 commits November 30, 2017 00:21

chore: Move MathJax from Bower to NPM

de7ef09

chore: Move Magnific Popup from Bower to NPM

82cab86

LaurentGoderre reviewed Dec 1, 2017

View reviewed changes

LaurentGoderre reviewed Dec 2, 2017

View reviewed changes

LaurentGoderre approved these changes Dec 5, 2017

View reviewed changes

LaurentGoderre merged commit ac343d8 into wet-boew:master Dec 5, 2017

nschonni deleted the bower-to-npm branch December 5, 2017 20:31

duboisp mentioned this pull request Dec 5, 2017

Revert "Bower to npm" #8228

Merged

duboisp mentioned this pull request Jan 9, 2018

Reapply - Bower to npm #8147 #8247

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bower to npm #8147

Bower to npm #8147

nschonni commented Sep 15, 2017 •

edited

Loading

LaurentGoderre commented Sep 18, 2017

nschonni commented Sep 18, 2017

LaurentGoderre commented Sep 18, 2017

duboisp commented Oct 12, 2017

nschonni Nov 23, 2017

nschonni commented Dec 1, 2017

lucas-hay commented Dec 1, 2017

nschonni commented Dec 1, 2017

lucas-hay commented Dec 1, 2017

LaurentGoderre Dec 1, 2017

nschonni Dec 1, 2017

LaurentGoderre Dec 2, 2017

LaurentGoderre Dec 2, 2017

nschonni Dec 2, 2017

jvanulde Dec 4, 2017

LaurentGoderre Dec 2, 2017

nschonni Dec 2, 2017

LaurentGoderre Dec 4, 2017

nschonni commented Dec 5, 2017

duboisp commented Dec 5, 2017

LaurentGoderre commented Dec 5, 2017

LaurentGoderre commented Dec 5, 2017

nschonni commented Dec 5, 2017

duboisp commented Dec 5, 2017

lucas-hay commented Dec 5, 2017

EricDunsworth commented Dec 5, 2017 •

edited

Loading

lucas-hay commented Dec 5, 2017

EricDunsworth commented Jan 8, 2018

duboisp commented Jan 9, 2018

LaurentGoderre commented Jan 9, 2018

Bower to npm #8147

Bower to npm #8147

Conversation

nschonni commented Sep 15, 2017 • edited Loading

LaurentGoderre commented Sep 18, 2017

nschonni commented Sep 18, 2017

LaurentGoderre commented Sep 18, 2017

duboisp commented Oct 12, 2017

Choose a reason for hiding this comment

nschonni commented Dec 1, 2017

lucas-hay commented Dec 1, 2017

nschonni commented Dec 1, 2017

lucas-hay commented Dec 1, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nschonni commented Dec 5, 2017

duboisp commented Dec 5, 2017

LaurentGoderre commented Dec 5, 2017

LaurentGoderre commented Dec 5, 2017

nschonni commented Dec 5, 2017

duboisp commented Dec 5, 2017

lucas-hay commented Dec 5, 2017

EricDunsworth commented Dec 5, 2017 • edited Loading

lucas-hay commented Dec 5, 2017

EricDunsworth commented Jan 8, 2018

duboisp commented Jan 9, 2018

LaurentGoderre commented Jan 9, 2018

nschonni commented Sep 15, 2017 •

edited

Loading

EricDunsworth commented Dec 5, 2017 •

edited

Loading