Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reapply - Bower to npm #8147 #8247

Closed
duboisp opened this issue Jan 9, 2018 · 1 comment
Closed

Reapply - Bower to npm #8147 #8247

duboisp opened this issue Jan 9, 2018 · 1 comment

Comments

@duboisp
Copy link
Member

duboisp commented Jan 9, 2018

The PR #8147 was reverted because it broke the build in various wet-boew theme such as GCWeb.

The goal is to reapply all the commits bundled with PR #8147 but without breaking the theme build.


@EricDunsworth wrote:

@duboisp @lucas-hay Are there any plans to re-implement this PR's changes (since #8228 reverted it)?

I personally would've preferred quick-fixing the other themes rather than reverting this PR. The changes it brought in were valid and didn't break this repo's build system.

IMO it would've been more ideal to fix the other themes' build systems - even if it resulted in 4.0.27 getting further delayed. Plus in the end, due to other issues, 4.0.27 didn't end up getting released until over a week after #8228 was merged in.

@duboisp wrote:

@EricDunsworth The first thing will be to have all those PR's ready to be merge. Then, after testing, we would be able to merge it and re-apply the change from this PR.

Feel free to submit all those related PR's then it can be merged all at once during a "PR review" meeting.

@nschonni
Copy link
Member

Fixed in #8253

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants