Unsupported types fail without reporting why

[bagmangood]

Detailed description

If an unsupported type is used in a json file (other than Data Types), the linter will solely output err is not defined.

It does report properly in a yaml file

To Replicate

1. Create a json file for some portion of your documentation.
2. Instead of a supported datatype, put foo.
3. Run the linter
4. Profit

[MikeRalphson]

@philsturgeon do you think this could be related to Mermade/oas-kit#78 or is it a separate issue?

[philsturgeon]

Sadly not @MikeRalphson, it's only when using -j and the invalid type is in a JSON Schema file.

The json-schema-to-openapi-schema library is throwing an exception that the oas-kit filter logic is not expecting.

▶ node speccy lint test/samples/json-schema/openapi.yaml -j --verbose
GET /Users/philsturgeon/src/speccy/rules/default.json
.. snip ..
GET test/samples/json-schema/openapi.yaml
GET /Users/philsturgeon/src/speccy/test/samples/json-schema/a.json
{ Error
    at Object.<anonymous> (/Users/philsturgeon/src/speccy/node_modules/json-schema-to-openapi-schema/index.js:8:30)
    at Module._compile (internal/modules/cjs/loader.js:689:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:700:10)
    at Module.load (internal/modules/cjs/loader.js:599:32)
    at tryModuleLoad (internal/modules/cjs/loader.js:538:12)
    at Function.Module._load (internal/modules/cjs/loader.js:530:3)
    at Module.require (internal/modules/cjs/loader.js:637:17)
    at require (internal/modules/cjs/helpers.js:20:18)
    at Object.<anonymous> (/Users/philsturgeon/src/speccy/lint.js:9:24)
    at Module._compile (internal/modules/cjs/loader.js:689:30)
  name: 'InvalidTypeError',
  message: 'Type "foo" is not a valid type' }
ReferenceError: err is not defined
    at /Users/philsturgeon/src/speccy/node_modules/oas-resolver/index.js:215:26
ReferenceError: err is not defined
    at /Users/philsturgeon/src/speccy/node_modules/oas-resolver/index.js:215:26
err is not defined

Not sure what to do about this.

[MikeRalphson]

@philsturgeon The throwing of the undefined err (when it should be ex) is fixed in oas-resolver v1.0.10

[philsturgeon]

Confirmed! Thank you so much @MikeRalphson.

$ speccy lint test/samples/json-schema/openapi.yaml -j
err is not defined
$ node speccy lint test/samples/json-schema/openapi.yaml -j
Type "foo" is not a valid type

This will be fixed by #181.