Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import notebooks from GitHub #55

Closed
Zarquan opened this issue Jan 27, 2020 · 16 comments
Closed

Import notebooks from GitHub #55

Zarquan opened this issue Jan 27, 2020 · 16 comments

Comments

@Zarquan
Copy link
Collaborator

Zarquan commented Jan 27, 2020

Initial step of importing notebooks from a publicly readable GitHib repository.

@NigelHambly
Copy link
Collaborator

This is available on the front page of the Zeppelin interface. No action needed.

@Zarquan
Copy link
Collaborator Author

Zarquan commented Feb 18, 2020

Looks like this is done.

@Zarquan Zarquan closed this as completed Feb 18, 2020
@Zarquan
Copy link
Collaborator Author

Zarquan commented Feb 18, 2020

Not done - I mis-read the title.

@stvoutsin
Copy link
Collaborator

Could we get some more context on this issue?
What Nigel was referring to, is that on the main page of Zeppelin you can import a notebook from a URL, so the basic functionality of importing from Github can be done. Is this task to do something more than that?

@NigelHambly
Copy link
Collaborator

I guess that's basically true, except that the spirit of this is to be able to easily preserve work outside of this cloud-based platform. As far as I can see I can export a json file to my local disk, I can then stick that in a repository from there. Furthermore I assume I can then import back via the URL option in the import note (correct? I haven't tried). But the former is one hop too many from a lazy person's viewpoint. I'd like to be able to import/export easily from/to the my external repository if possible.

@Zarquan
Copy link
Collaborator Author

Zarquan commented Apr 9, 2020

What I had in mind having an 'import from GitHub' button that enabled you browse and pull notebooks from GitHub without having to explicitly copy/paste URLs. Longer term goal of being able to link your account with your GitHub account and then be able to import and export to/from a GitHub repository.

@Zarquan
Copy link
Collaborator Author

Zarquan commented Apr 9, 2020

Example of this is the GitHub integration in Overleaf.
You can link an Overleaf document with a GitHub repository, and then you can sync your document in Overleaf with the copy in GitHub using a button in the Overleaf editor menu.
menu-select

The Overleaf editor pops up a dialog window like this ..
Screenshot at 2020-04-09 16-46-27

Selecting 'commit' gives you the option to add a commit message and then pushes changes from Overleaf into GitHub.
Screenshot at 2020-04-09 16-46-46

To achieve this, Overleaf is keeping track of an association between this Overleaf project and the GitHub repository that it came from, and Overleaf asked me to grant permission to register the Overleaf service as an OAuth application with access to my GitHub account.

Once it is registered as an OAuth application Overleaf shows up in the list of applications that have been granted write access to my GitHub account.
Screenshot at 2020-04-09 17-08-24

This sounds complicated, but a lot of it should be covered by 3rd party libraries that implement support for OAuth applications.

@Zarquan
Copy link
Collaborator Author

Zarquan commented Apr 9, 2020

@Zarquan
Copy link
Collaborator Author

Zarquan commented Apr 10, 2020

Ok, so to be able to move this on, do we split it into stages ?

  1. Import from URL (copy/paste)
  2. Import from GitHub, read only (public repo, git clone)
  3. Register with GitHub as an OAuth application
  4. Import/export from GitHub, read/write (OAuth application)

What do we want to see in the GUI at each stage ?

@NigelHambly
Copy link
Collaborator

As mentioned during our last catch-up, at this stage I'd like to establish a road map to getting from where we are now to where we want to be at the end of this year, i.e. deployment of a reasonably user-friendly, stable system that friendly UK-based astronomers can try out. Broad concept of the top level look-and-feel of any GUI should come first, and could be included in such a road map. No harm in rapping over gory details at this stage, but I'd like to see the road map in place asap.

@Zarquan
Copy link
Collaborator Author

Zarquan commented Jun 11, 2020

If we are going to have a separate web interface for Aglais, a landing website where users manage their accounts and bookings, then the GitHub integration would be part of that.
The outline and screen shots are still applicable, just as part of the Aglais pages not the Zeppelin pages.

@Zarquan
Copy link
Collaborator Author

Zarquan commented Jul 3, 2020

Not a priority for the December release.

@Zarquan Zarquan closed this as completed Jul 3, 2020
@Zarquan
Copy link
Collaborator Author

Zarquan commented Oct 29, 2020

OK - looks like this might be important for December so I'm re-opening it.

@Zarquan Zarquan reopened this Oct 29, 2020
@Zarquan
Copy link
Collaborator Author

Zarquan commented Oct 29, 2020

The hope is that a lot of this functionality is now available in Zeppelin. So first part of this task is to look at what is available "out of the box" in Zeppelin.

@Zarquan
Copy link
Collaborator Author

Zarquan commented Dec 15, 2020

Looks like the Zeppelin functionality attaches a single GitHub account for all the notebooks.
We haven't found a way of doing this on a per user basis yet.

@Zarquan
Copy link
Collaborator Author

Zarquan commented Mar 8, 2022

Been there, done that.

@Zarquan Zarquan closed this as completed Mar 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants