Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modal not showing data - only undefined #34

Open
webnoob opened this issue Jan 1, 2017 · 11 comments
Open

Modal not showing data - only undefined #34

webnoob opened this issue Jan 1, 2017 · 11 comments

Comments

@webnoob
Copy link

webnoob commented Jan 1, 2017

I have the following:

<modal title="Make Payment" v-model="modelProp.value">
  <div slot="modal-header" class="modal-header">
    <h4 class="modal-title">Make a payment</h4>
  </div>
  <div>
    <p>Make a payment</p>
    <input type="text" v-model="paidAmount"/>
  </div>
</modal>

And when I click my button to trigger the modal, I get the modal itself show and the background fade out however, the content shows "undefined, undefined, undefined". This was working a few days ago and the only thing I can see that has changed is that I've done a fresh npm install so have the latest build now.

This is what shows:

image

This the element source:

<div role="dialog" class="modal in" style="display: block;">
  <div role="document" class="modal-dialog">
    <div class="modal-content">undefined undefined undefined</div>
  </div>
</div>

Any clues?

@webnoob
Copy link
Author

webnoob commented Jan 1, 2017

I'v just noticed from this thread: #31 that it's been advised to update to the later version of vue. I'm trying this now to see if it helps my issue.

EDIT: It doesn't help. I'm now running vue 2.1.8 and the issue remains. Unfortunately, I don't know which version I was running when it was working properly but it would have been from the middle of last week I believe.

@gholol
Copy link

gholol commented Jan 2, 2017

@webnoob This is caused by the normalization bug https://github.com/vuejs/vue/pull/4572/files

It's affecting multiple components, fix is coming with the 2.1.9 release.
For now downgrade your vue and vue-template-compiler to 2.1.6

@webnoob
Copy link
Author

webnoob commented Jan 2, 2017

@gholol Thanks for that, it appears to have fixed the issue.

@webnoob webnoob closed this as completed Jan 2, 2017
@dontfeedthecode
Copy link

@webnoob @gholol FYI I've just updated to 2.1.9 and the problem persists.

@webnoob
Copy link
Author

webnoob commented Jan 17, 2017

Are we sure this is a problem with Vue and not with vue-strap in that case? Has something changed in the latest vue version which requires changes within vue-strap?

@webnoob webnoob reopened this Jan 17, 2017
@poppabear8883
Copy link

I can confirm this issue is still persistent in 2.1.10 ... #41

@PsychicCat PsychicCat mentioned this issue Jan 19, 2017
@gholol
Copy link

gholol commented Jan 20, 2017

@webnoob

Are we sure this is a problem with Vue and not with vue-strap in that case?

Yes because it works as soon as you downgrade to 2.1.6

@webnoob
Copy link
Author

webnoob commented Jan 20, 2017

That just means that the code in vue-strap works with the code in vue 2.1.6 not that vue has changed something that it's not intending to fix and vue-strap also needs to adhere to that change.

@poppabear8883
Copy link

@gholol @webnoob see #43 #41 .. needs a new build

@wffranco
Copy link
Owner

last build with vue 2.1.10

@stefanoborini
Copy link

stefanoborini commented May 9, 2017

Still present in vue 2.3.2 and vue-strap 2.0.0beta1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants