Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

StepNavigationItem types ver 1.21.1 #546

Closed
skorekm opened this issue Aug 4, 2022 · 0 comments
Closed

StepNavigationItem types ver 1.21.1 #546

skorekm opened this issue Aug 4, 2022 · 0 comments

Comments

@skorekm
Copy link
Contributor

skorekm commented Aug 4, 2022

It looks like the typescript interface for the StepNavigationItem differs from the propTypes in the 1.21.1 version

Detailed description

Describe in detail the issue you're having.

The typescript interface for the StepNavigationItem is missing a page prop. Also, the renderAnchor prop is not optional as it's supposed to be.

Is this a feature request (new component, new icon), a bug, or a general issue?

It's a bug

Is this issue related to a specific component?

Yeah, it's related to the StepNavigationItem

What offering/product do you work on? Any pressing ship or release dates we should be aware of?
I am working on the Partner Connect project.

Additional information

This was discussed on the slack ux-ui channel
@skorekm skorekm mentioned this issue Aug 4, 2022
Merged
Utzel-Butzel added a commit that referenced this issue Aug 6, 2022
@Utzel-Butzel
Merge pull request #547 from skorekm/fix/StepNavigation-props
eac024b 
fix: update StepNavigationItem interface, resolves #546
Utzel-Butzel pushed a commit that referenced this issue Aug 6, 2022
@semantic-release-bot
chore(release): 1.22.0 [skip ci]
f01d8f2 
# [1.22.0](v1.21.1...v1.22.0) (2022-08-06)

### Bug Fixes

* unexpected value in the types import ([45497e3](45497e3))
* update StepNavigationItem interface, resolves [#546](#546) ([78a4f99](78a4f99))

### Features

* extend SingleDatePickerInput interface and propTypes, resolves [#548](#548) ([8550f54](8550f54))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@skorekm