Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SingleDatePickerInput does not accept react component in the datePicker prop #548

Closed
skorekm opened this issue Aug 5, 2022 · 0 comments
Closed

SingleDatePickerInput does not accept react component in the datePicker prop #548

skorekm opened this issue Aug 5, 2022 · 0 comments

Comments

@skorekm
Copy link
Contributor

skorekm commented Aug 5, 2022

SingleDatePickerInput does not accept react component in the datePicker prop

Detailed description

Describe in detail the issue you're having.

I am trying to use the DateRangePickerInput together with the DateRangePicker from the react-dates library. Unfortunately, I noticed that DateRangePickerInput accepts only function or an object as the datePicker prop. My suggestion is to extend it to also accept React.ReactNode.

Is this a feature request (new component, new icon), a bug, or a general issue?

Feature request

Is this issue related to a specific component?

Yeah, DateRangePickerInput, which partially takes its interface from the SingleDatePickerInput

What version of the WFP UI (Carbon Design System) are you using?

1.21.1
@skorekm skorekm mentioned this issue Aug 5, 2022
Merged
Utzel-Butzel pushed a commit that referenced this issue Aug 6, 2022
@semantic-release-bot
chore(release): 1.22.0 [skip ci]
f01d8f2 
# [1.22.0](v1.21.1...v1.22.0) (2022-08-06)

### Bug Fixes

* unexpected value in the types import ([45497e3](45497e3))
* update StepNavigationItem interface, resolves [#546](#546) ([78a4f99](78a4f99))

### Features

* extend SingleDatePickerInput interface and propTypes, resolves [#548](#548) ([8550f54](8550f54))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@skorekm